Improve grammar in doc/flatpak-manifest.xml #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwakely
commented
Mar 13, 2023
The first "Extension" is referring to the item type itself. You could probably omit it and say:
|
Yes, the same thought had occurred to me. I'll push an update to the branch. |
hfiguiere
reviewed
Nov 19, 2023
| <listitem><para>By default (if strip is not true) flatpak-builder extracts all debug info in ELF files to a separate files | ||
| and puts this in an extension. If you want to disable this, set no-debuginfo to true.</para></listitem> | ||
| <listitem><para>By default (if strip is not true) flatpak-builder extracts all debug info in ELF files to separate files | ||
| and puts them in an extension. If you want to disable this, set no-debuginfo to true.</para></listitem> |
There was a problem hiding this comment.
Suggested change
| and puts them in an extension. If you want to disable this, set no-debuginfo to true.</para></listitem> | |
| and puts them into an extension. If you want to disable this, set no-debuginfo to true.</para></listitem> |
hfiguiere
reviewed
Nov 19, 2023
| @@ -132,7 +132,7 @@ | |||
| <term><option>command</option> (string)</term> | |||
| <listitem><para> | |||
| The filename or path to the main binary of the application. Note that this | |||
| is really just a single file, not a commandline. If you want to pass arguments, | |||
| must be just a single file, not a commandline. If you want to pass arguments, | |||
There was a problem hiding this comment.
Suggested change
| must be just a single file, not a commandline. If you want to pass arguments, | |
| must be just a single command name, not a commandline, nor path. If you want to pass arguments, | |
| or run from a location not in PATH, |
hfiguiere
reviewed
Nov 19, 2023
| @@ -377,7 +377,7 @@ | |||
| </varlistentry> | |||
| <varlistentry> | |||
| <term><option>secret-env</option> (array of strings)</term> | |||
| <listitem><para>This is a array defining which host environment variables is transfered to build-commands or post-install environment.</para></listitem> | |||
| <listitem><para>This is a array defining which host environment variables are transfered to the build-commands or post-install environment.</para></listitem> | |||
There was a problem hiding this comment.
Suggested change
| <listitem><para>This is a array defining which host environment variables are transfered to the build-commands or post-install environment.</para></listitem> | |
| <listitem><para>This is an array defining which host environment variables are transfered to the build-commands or post-install environment.</para></listitem> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what the sentence "Extension define extension points in the app/runtime that can be implemented by extensions, supplying extra files which are available during runtime" is really trying to say (it uses the word extension too many times!) but I think this is better.
I'm also not sure exactly what the
no-debuginfodescription is saying. Please check my changes make sense.