Improve handling of a symlinked application directory #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `--force-clean` is passed, clear (remove the contents of) the target (app) directory without deleting the directory itself. This is useful if the app directory is a symlink, e. g. to a faster disk or a scratch location. Submodule subprojects/libglnx 07e3e49d..1a503dcc: > shutil: add glnx_shutil_rm_rf_children_at() > shutil: specify symlink behavior of glnx_shutil_rm_rf_at(), add tests > tests: add a macro to check for positive errno
We only care about the app (== target) directory, not its parent. This breaks if the target directory is a symlink, like this: ``` $ pwd /path/to/code $ realpath state /path/to/scratch/state $ realpath build /path/to/scratch/target $ flatpak-builder --state-dir=state build org.some.App.yaml The state dir (/path/to/scratch/state) is not on the same filesystem as the target dir (/path/to/code) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes to better handle a case where the application directory is a symlink (e. g. to a faster/larger storage or a scratch location):
--force-cleanis passed, only clear the contents of the application directory, not the dir itself;I had to write some new code in libglnx which is tracked in this MR: https://gitlab.gnome.org/GNOME/libglnx/-/merge_requests/49