Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split autotools and meson #608

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Split autotools and meson #608

merged 1 commit into from
Jul 5, 2024

Conversation

nanonyme
Copy link
Contributor

@nanonyme nanonyme commented Jul 1, 2024

autotools is not really autotools but covers arbitrary legacy build systems using make. It's not safe to touch arguments there.

@nanonyme nanonyme mentioned this pull request Jul 1, 2024
Closed
@nanonyme
Split autotools and meson
f6f56db 
autotools is not really autotools but covers arbitrary legacy
build systems using make. It's not safe to touch arguments
there. This also reverts tests to what they were.
@nanonyme
Copy link
Contributor Author

nanonyme commented Jul 1, 2024

I guess the fact tests needed changing in previous PR should have rung alarm bells.

@nanonyme
Copy link
Contributor Author

nanonyme commented Jul 1, 2024

@TingPing do you have time to look at this?

@TingPing
Copy link
Member

TingPing commented Jul 3, 2024

I don't have a super strong opinion.

I think Perl is a rare example of a configure script that doesn't support this and the simple build type exists for anything that falls out of scope.

@bbhtt
Copy link
Contributor

bbhtt commented Jul 4, 2024 •
edited
Loading

The other issue with #588 is CMAKE_INSTALL_LIBDIR is not an absolute path https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html#result-variables

CMAKE_INSTALL_<dir>

It should be a path relative to the installation prefix

But it is being set to /app/lib when it should've been lib. CMAKE_INSTALL_FULL_LIBDIR is supposed to be absolute.

The non FULL paths are always taken relative to CMAKE prefix.

This is now causing flathub/io.github.martinrotter.rssguard#73 (comment)

I'll patch it again in org.flatpak.Builder

@bbhtt bbhtt mentioned this pull request Jul 4, 2024
Closed
@TingPing
Copy link
Member

TingPing commented Jul 4, 2024

Can you submit a PR for that?

@TingPing TingPing merged commit 21b1fbb into flatpak:main Jul 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nanonyme @TingPing @bbhtt