Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to source for command reference docs #134

Closed
wants to merge 1 commit into from

Conversation

takluyver
Copy link

I wanted to contribute to the reference docs, and was temporarily confused about where they come from. So once I worked it out, I thought I'd clarify it for anyone else who reaches the same place.

The .. syntax is a rst comment, so these messages are only visible to people looking at the docs source.

@allanday
Copy link
Collaborator

Since this page is generated, I don't think we can manually add text. Maybe @mwleeds can advise...

@takluyver
Copy link
Author

It looks like the HTML file is generated - the rst files I modified are just stubs that point to the HTML.

mwleeds added a commit to flatpak/flatpak that referenced this pull request Jul 7, 2018
When you're looking at the Flatpak Command Reference on
docs.flatpak.org, it's not clear that it was generated from the flatpak
repo. So add a notice to the docbook that's used to generate the HTML.
This was pointed out by
flatpak/flatpak-docs#134
mwleeds added a commit to flatpak/flatpak-builder that referenced this pull request Jul 7, 2018
When you're looking at the Flatpak Builder Command Reference on
docs.flatpak.org, it's not clear that it was generated from the
flatpak-builder repo. So add a notice to the docbook that's used to
generate the HTML. This was pointed out by
flatpak/flatpak-docs#134
@mwleeds
Copy link
Collaborator

mwleeds commented Jul 7, 2018

(Sorry I didn't see the notification from this.)

While the rst files are not generated, it also doesn't seem to work to add text like this, based on checking the output after running make html. So instead I added a notice to the XML used to generate the HTML: see flatpak/flatpak@1a79b46 and flatpak/flatpak-builder@89f1fd5

@mwleeds mwleeds closed this Jul 7, 2018
@takluyver
Copy link
Author

It wasn't mean to add text in the output - it was a comment in the source code. It's entirely possible to add text in the rst as well - just write normal text without the ...

@mwleeds
Copy link
Collaborator

mwleeds commented Jul 7, 2018

Oh! Well we could do both then

@takluyver
Copy link
Author

My process was that I clicked the "Edit on Github" link and got to this page. But I'd probably have seen the generated notice you've now got on the webpage, so I think that's a satisfactory solution too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants