Skip to content

Commit

Permalink
validate-icon: For completeness, always add "--" to bwrap arguments
Browse files Browse the repository at this point in the history
This particular bwrap invocation cannot cause a sandbox escape because
the command to run is hard-coded, but it's more clearly correct if we
pass "--" to every bwrap invocation.

Signed-off-by: Simon McVittie <smcv@collabora.com>
  • Loading branch information
smcv committed Apr 17, 2024
1 parent c95214b commit c777f81
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion icon-validator/validate-icon.c
Expand Up @@ -228,7 +228,7 @@ rerun_in_sandbox (const char *arg_width,
if (g_getenv ("G_MESSAGES_PREFIXED"))
add_args (args, "--setenv", "G_MESSAGES_PREFIXED", g_getenv ("G_MESSAGES_PREFIXED"), NULL);

add_args (args, validate_icon, arg_width, arg_height, filename, NULL);
add_args (args, "--", validate_icon, arg_width, arg_height, filename, NULL);
g_ptr_array_add (args, NULL);

{
Expand Down

0 comments on commit c777f81

Please sign in to comment.