-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtimes should be able to remove files from the runtimes they're based on #1024
Comments
I have not yet imported the latest build to stable, but i just tried the build in http://sdkbuilder1.gnome.org/repo/ and it did indeed fix the warnings from gst-inspect-1.0 |
I tried your example here with: flatpak-0.9.10-1.fc26.x86_64 |
I got some troubles running a webkit2gtk based app inside the gnome platform 3.26, WebKitWebProcess printing many warnings about gstreamer. I'm posting this here cause this seems to be related to blacklisted gstreamer plugins as this output proves.
I don't know how works gstreamer in details but those problems doesn't appears when running this command on the sdk runtime. Maybe some files required by gstreamer are removed during the cleanup-platform process. My skills stop there. Good luck.
|
Yeah, it seems we're removing the base gstreamer plugins from the sdk only, not the platform, this needs some flatpak-builder support i believe. |
This fixes the issue in: flatpak/flatpak#1024 (comment) Where we removed the base platform gstreamer plugins in the the sdk, but they were not removed in the platform.
I suspect that the commit https://git.gnome.org/browse/gnome-sdk-images/commit/?h=gnome-3-26&id=2b1dc1b1ad84bddc932da2395a96d5a7e4c4fad0 isn't actually doing anything. (I updated to the latest org.gnome.Sdk//3.26 and the gstreamer plugin scanner is still crashing, causing plugins to be blacklisted.)
Here's a minimal runtime manifest that builds fine for me (flatpak 0.9.8, ostree 2017.10) but you can verify in a shell in the sandbox that
/usr/lib/gstreamer-1.0
is still there and full of plugins:The text was updated successfully, but these errors were encountered: