Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm %post incompatible with ostree-for-system #113

Closed
cgwalters opened this issue Jun 13, 2016 · 9 comments
Closed

rpm %post incompatible with ostree-for-system #113

cgwalters opened this issue Jun 13, 2016 · 9 comments
Milestone

Comments

@cgwalters
Copy link
Collaborator

Ironically,

%post
# Create an (empty) system-wide repo.
flatpak remote-list --system

won't work in an OSTree-for-system model. I think the privileged helper needs to create-if-not-exists?

@alexlarsson
Copy link
Member

We discussed this a bit, and I think the proper fix is for flatpak to handle a non-existing system repo in a non-fatal way, at least for the reading operations (list apps, list remotes, etc) this is simple, just return the empty lists. Then we need to make "add system remote" work for that case too.

I looked into this, and there are some complexities wrt libflatpak threadsafety that makes this somewhat hard, but it should be doable with some care.

@cgwalters
Copy link
Collaborator Author

Or we could install a systemd unit file which does create-if-not-exists ?

@cgwalters
Copy link
Collaborator Author

A workaround for this issue is to simply sudo flatpak remote-list --system.

@cgwalters
Copy link
Collaborator Author

This is still biting people trying out https://fedoraproject.org/wiki/Workstation/AtomicWorkstation .

WDYT about the systemd unit approach?

@cgwalters
Copy link
Collaborator Author

(I can write that patch easily enough...reworking flatpak like #113 (comment) would require me to learn a lot more of flatpak than I know right now)

@matthiasclasen
Copy link
Collaborator

I just ran into this again when trying atomic workstation. This pretty much breaks the out-of-the-box experience of gnome-software. We should really fix this

@matthiasclasen
Copy link
Collaborator

I think it would be great to have a systemd unit in the atomic workstation as a workaround until flatpak learns how to deal with nonexistent repos gracefully.

@cgwalters
Copy link
Collaborator Author

OK, I'll write one.

@cgwalters
Copy link
Collaborator Author

alexlarsson added a commit to alexlarsson/flatpak that referenced this issue Nov 23, 2017
This means flatpak can bootstrap itself from an empty /var on stateless
systems, which fixes flatpak#113, at
least for the CLI case.
kalev added a commit to kalev/flatpak that referenced this issue Jan 31, 2018
Similar to commit 6bb0196 that fixed
flatpak#113 for the flatpak CLI, this
fixes the library so that gnome-software works with an empty
/var/lib/flatpak.
rh-atomic-bot pushed a commit that referenced this issue Feb 7, 2018
Similar to commit 6bb0196 that fixed
#113 for the flatpak CLI, this
fixes the library so that gnome-software works with an empty
/var/lib/flatpak.

Closes: #1368
Approved by: alexlarsson
alexlarsson pushed a commit that referenced this issue Feb 7, 2018
Similar to commit 6bb0196 that fixed
#113 for the flatpak CLI, this
fixes the library so that gnome-software works with an empty
/var/lib/flatpak.

Closes: #1368
Approved by: alexlarsson

(cherry picked from commit a9b6e31)
mwleeds pushed a commit to endlessm/flatpak that referenced this issue Apr 7, 2018
Similar to commit 6bb0196 that fixed
flatpak/flatpak#113 for the flatpak CLI, this
fixes the library so that gnome-software works with an empty
/var/lib/flatpak.

Closes: #1368
Approved by: alexlarsson
mwleeds pushed a commit to endlessm/flatpak that referenced this issue Apr 7, 2018
Similar to commit 6bb0196 that fixed
flatpak/flatpak#113 for the flatpak CLI, this
fixes the library so that gnome-software works with an empty
/var/lib/flatpak.

Closes: #1368
Approved by: alexlarsson
uajain pushed a commit to uajain/flatpak that referenced this issue Oct 12, 2018
Installation: Add flatpak_installation_get_min_free_space_bytes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants