Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'flatpak remote-delete' does not remove all refs it says it will #2757

Closed
mcatanzaro opened this issue Mar 14, 2019 · 2 comments
Closed

'flatpak remote-delete' does not remove all refs it says it will #2757

mcatanzaro opened this issue Mar 14, 2019 · 2 comments
Labels
bug

Comments

@mcatanzaro
Copy link
Collaborator

Linux distribution and version

Fedora 30

Flatpak version

flatpak-1.2.3-2.fc30

Description of the problem

flatpak remote-delete says it will remove all refs installed from that remote, but it doesn't actually do so.

Steps to reproduce

$ sudo flatpak remote-delete gnome-nightly
The following refs are installed from remote 'gnome-nightly':

   1) runtime/org.gnome.Platform/x86_64/master
   2) runtime/org.gnome.Platform.Locale/x86_64/master
   3) runtime/org.gnome.Sdk.Locale/x86_64/master
   4) runtime/org.gnome.Sdk.Docs/x86_64/master
   5) runtime/org.gnome.Sdk.Debug/x86_64/master
   6) runtime/org.gnome.Sdk/x86_64/master

Remove them? [y/n]: y
Uninstalling runtime/org.gnome.Platform/x86_64/master

It didn't even uninstall runtime/org.gnome.Platform/x86_64/master, though. I still have that installed when I check with flatpak list. I think it's just failed without printing any error message.
@mcatanzaro
Copy link
Collaborator Author

Note: uninstalling them all manually with flatpak uninstall works perfectly fine.

@mwleeds mwleeds added the bug label Mar 15, 2019
@mwleeds mwleeds mentioned this issue Apr 18, 2019
Closed
alexlarsson added a commit to alexlarsson/flatpak that referenced this issue Apr 25, 2019
@alexlarsson
Fix install --noninteractive not reporting errors
5a65850 
We need to handle operation_error and report errors, and for
fatal errors remember this and report a failure in run(), because
otherwise it returns ABORTED, which is treated as a failure (because
generally that meant the user chose "no" on some question).

Fixes flatpak#2839, flatpak#2757
rh-atomic-bot pushed a commit that referenced this issue Apr 25, 2019
@alexlarsson @rh-atomic-bot
Fix install --noninteractive not reporting errors
e1f45a3 
We need to handle operation_error and report errors, and for
fatal errors remember this and report a failure in run(), because
otherwise it returns ABORTED, which is treated as a failure (because
generally that meant the user chose "no" on some question).

Fixes #2839, #2757

Closes: #2858
Approved by: alexlarsson
@alexlarsson
Copy link
Member

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexlarsson @mcatanzaro @mwleeds