Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.12.1 unit test failure on Ubuntu 18.04: test_languages_config: assertion failed (value[0] == "en"): (NULL == "en") #4471

Closed
smcv opened this issue Oct 10, 2021 · 0 comments · Fixed by #4472
Closed

1.12.1 unit test failure on Ubuntu 18.04: test_languages_config: assertion failed (value[0] == "en"): (NULL == "en") #4471

smcv opened this issue Oct 10, 2021 · 0 comments · Fixed by #4472

Comments

@smcv
Copy link
Collaborator

smcv commented Oct 10, 2021

Linux distribution and version

Ubuntu 18.04 (in particular libglib2.0-dev_2.56.4-0ubuntu0.18.04.8)

Flatpak version

1.12.1 patched with #4461

Description of the problem

https://launchpad.net/~smcv/+archive/ubuntu/flatpak-test-stable/+build/22265505

PASS: testlibrary 1 /library/version
PASS: testlibrary 2 /library/types
PASS: testlibrary 3 /library/user-installation
PASS: testlibrary 4 /library/system-installation
PASS: testlibrary 5 /library/multiple-system-installation
PASS: testlibrary 6 /library/installation-config
ERROR: testlibrary - Bail out! flatpak:ERROR:tests/testlibrary.c:299:test_languages_config: assertion failed (value[0] == "en"): (NULL == "en")

I'm guessing this is a problem with the backport in #3712?

Steps to reproduce

Build 1.12.1 in a PPA
smcv added a commit to smcv/flatpak that referenced this issue Oct 10, 2021
@smcv
common: Backport g_get_language_names_with_category() more thoroughly
af17f69 
Even though we are going to check all the `LC_*` environment variables,
if one of them is not set, we still need to consider LANGUAGE, LC_ALL
and LANG; there is no guarantee that *every* `LC_*` environment variable
is set (and in particular, during our build-time tests, they will usually
not be).

Resolves: flatpak#4471
Signed-off-by: Simon McVittie <smcv@collabora.com>
@smcv smcv mentioned this issue Oct 10, 2021
Merged
alexlarsson pushed a commit that referenced this issue Oct 11, 2021
@smcv @alexlarsson
common: Backport g_get_language_names_with_category() more thoroughly
ae59fb7 
Even though we are going to check all the `LC_*` environment variables,
if one of them is not set, we still need to consider LANGUAGE, LC_ALL
and LANG; there is no guarantee that *every* `LC_*` environment variable
is set (and in particular, during our build-time tests, they will usually
not be).

Resolves: #4471
Signed-off-by: Simon McVittie <smcv@collabora.com>
alexlarsson pushed a commit that referenced this issue Oct 11, 2021
@smcv @alexlarsson
common: Backport g_get_language_names_with_category() more thoroughly
72c38fe 
Even though we are going to check all the `LC_*` environment variables,
if one of them is not set, we still need to consider LANGUAGE, LC_ALL
and LANG; there is no guarantee that *every* `LC_*` environment variable
is set (and in particular, during our build-time tests, they will usually
not be).

Resolves: #4471
Signed-off-by: Simon McVittie <smcv@collabora.com>
(cherry picked from commit ae59fb7)
@smcv smcv mentioned this issue Oct 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

common: Backport g_get_language_names_with_category() more thoroughly smcv/flatpak
1 participant
@smcv