Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

claims to work with GLib 2.40 but actually needs 2.44 #622

Closed
smcv opened this issue Mar 12, 2017 · 1 comment
Closed

claims to work with GLib 2.40 but actually needs 2.44 #622

smcv opened this issue Mar 12, 2017 · 1 comment

Comments

@smcv
Copy link
Collaborator

smcv commented Mar 12, 2017

configure.ac says flatpak 0.8.x only needs GLib 2.40, but it actually uses G_DECLARE_FINAL_TYPE, which was introduced in 2.44.

I have patched the jessie-backports version to cope, but the patches are fairly nasty, particularly the second one (I had to copy in half of gtype.h):

Assuming you don't like those patches (in your place I wouldn't!), I suspect the best solution upstream might be to just bump GLIB_REQS to 2.44, and then I can patch that back to 2.40 for the jessie backport.

@alexlarsson
Copy link
Member

Yeah, i think going with 2.44 is ok at this point.

alexlarsson added a commit that referenced this issue Apr 3, 2017
This is required for e.g. G_DECLARE_FINAL_TYPE, and most current
distros have this now.

This fixes #622

For distributions that want to build against older glib, see
the issue above, it has patches to make that work.

(cherry picked from commit dcccb3c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants