Refactor common/flatpak-instance, add test coverage #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyuzakiKK
reviewed
Feb 17, 2021
|
This looks good to me. |
This localizes knowledge of the internal structure of $XDG_RUNTIME_DIR/.flatpak into the flatpak-instance module. Signed-off-by: Simon McVittie <smcv@collabora.com>
The only functional change here is that we consistently use flatpak_get_real_xdg_runtime_dir(), instead of a mixture of the versions with and without realpath(). Signed-off-by: Simon McVittie <smcv@collabora.com>
Signed-off-by: Simon McVittie <smcv@collabora.com>
If these simple libc function wrappers fail during setup, we want to crash out. Signed-off-by: Simon McVittie <smcv@collabora.com>
Signed-off-by: Simon McVittie <smcv@collabora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common: Move flatpak_run_allocate_id() to flatpak-instance
This localizes knowledge of the internal structure of
$XDG_RUNTIME_DIR/.flatpak into the flatpak-instance module.
instance: Factor out flatpak_instance_get_instances_directory
The only functional change here is that we consistently use
flatpak_get_real_xdg_runtime_dir(), instead of a mixture of
the versions with and without realpath().
tests: Factor out test setup from test-exports
tests: Improve error handling for isolated directory setup
If these simple libc function wrappers fail during setup, we want to
crash out.
tests: Add basic test coverage for GC'ing unused instance directories
Required by #4126 and #4093.