revokefs: Use FUSE version 3 if possible #4326
Conversation
|
Do we have some test suite that makes sure flatpak keeps building under both setups? |
That's certainly something I should add before marking this as ready. (It is not ready.) Actually testing the result on a real system with working FUSE, and checking that it works, is also a prerequisite for marking this MR as ready. |
smcv
force-pushed
the
fuse3
branch
3 times, most recently
from
9d90855
to
aa824e5
Compare
smcv
force-pushed
the
fuse3
branch
2 times, most recently
from
250a8aa
to
55b767d
Compare
|
This probably shouldn't be merged with "Use a libostree with ostreedev/ostree#2592 fixed" included, but I want to see whether that change fixes the CI. A better way to avoid that bug would be to either wait for the fix to be merged in libostree, or add a suppression. |
smcv
force-pushed
the
fuse3
branch
2 times, most recently
from
4c89b8b
to
9c4a6a2
Compare
Flatpak's test-suite passes on Debian unstable (locally) and Ubuntu 18.04 (on CI) with FUSE 2, and on Debian unstable (locally) and Ubuntu 20.04 (on CI) with FUSE 3.
That change did fix the CI. I've now replaced it with a valgrind suppression, which will hopefully also fix the CI. |
(It did) |
|
Adding this to the 1.16.0 milestone since it otherwise may not get enough testing if it's released in 1.14.0, based on discussion in the BoF session. Feel free to disagree Simon |
How soon is 1.14.0 planned to happen, and how much testing do we expect to need for this? Distributions seem quite keen to move on from FUSE 2 to FUSE 3. |
|
Honestly, i think we should just merge this. Its up to distros that want to switch to fuse3 to test it, and the code looks sane to me (and doesn't really change a lot). @smcv can you resolve the conflicts? |
Based on a change contributed by Léo Stefanesco; but instead of unconditionally using FUSE 3, leave a fallback code path for FUSE 2 for older distros. Co-authored-by: Léo Stefanesco <leo.lveb@gmail.com> Signed-off-by: Simon McVittie <smcv@collabora.com>
This is fixed in v2022.3, but that version missed the boat for Ubuntu 22.04. Signed-off-by: Simon McVittie <smcv@collabora.com>
This ensures we exercise both code paths. Signed-off-by: Simon McVittie <smcv@collabora.com>
Done. Now that we have an Ubuntu 22.04 CI pass, I used that as the one that targets fuse3, while keeping 20.04 and 18.04 on fuse 2. |
revokefs: Use FUSE version 3 if possible
Based on a change contributed by Léo Stefanesco (Update to fuse vervion 3 #3661); but instead of
unconditionally using FUSE 3, leave a fallback code path for FUSE 2 for
older distros.
Co-authored-by: @ineol
tests: Add valgrind suppression for OstreeRepoAutoTransaction used with uninitialized refcount in ostree_repo_prepare_transaction() ostreedev/ostree#2592
This is fixed in v2022.3, but that version missed the boat for Ubuntu
22.04.
workflows: Build with FUSE 3 for Ubuntu 22.04
This ensures we exercise both code paths.