Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --socket=gpg-agent #4958

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Conversation

bl00mber
Copy link
Contributor

close #2301

@Erick555
Copy link
Contributor

In previous attempt there was problem with gnupg parent folder that contains sockets - gpg requires it to have 700 unix permissions while bwrap by default uses 755. Are you sure it's no longer a concern? Since then bwrap gained way to override permissions but it needs to be used.

@bl00mber bl00mber marked this pull request as draft June 20, 2022 22:03
@bl00mber bl00mber marked this pull request as ready for review June 20, 2022 23:09
@bl00mber
Copy link
Contributor Author

@Erick555 I've managed to run gpg-agent dependent application tasks from flatpak, as well as gpg

@Erick555
Copy link
Contributor

Yeah, the permission problem seems to be fixed since version 1.11

@bl00mber
Copy link
Contributor Author

Can you merge @mwleeds @alexlarsson

@mwleeds
Copy link
Collaborator

mwleeds commented Jun 27, 2022

If you add a new socket you need to update the man pages for the build-finish, build, override, and run commands. Ideally there should be a unit test as well if it's technically feasible.

@bl00mber
Copy link
Contributor Author

bl00mber commented Jul 1, 2022

I updated manpages @mwleeds not sure how to make a socket test though, it seems there are no other socket that is covered by test of its direct functionality

@mwleeds
Copy link
Collaborator

mwleeds commented Jul 24, 2022

Can you squash the three commits into one? Here is how to do it:

  1. git rebase -i a421e1cc6f78649ea75118404d07b410a7f13e1d^
  2. Edit the two subsequent commits to have "fixup" rather than "pick" as the first word
  3. Save and exit the editor
  4. Force push with git push -f <remote_name> add-socket-gpg-agent, but use the actual remote name

@bl00mber
Copy link
Contributor Author

@mwleeds done

common/flatpak-run.c Outdated Show resolved Hide resolved
common/flatpak-run.c Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gpg-agent socket
5 participants