Allow sub-sandboxes to own MPRIS names #5023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love some opinion on if the |
We already allow normal apps to own MPRIS names but subsandboxes could not. This allows them with the same dbus restrictions that they must be prefixed by $app_id.Sandboxed. This will be used by WebKitGTK.
TingPing
force-pushed
the
pgriffis/mpris-sandboxed
branch
from
687eadd
to
1664f37
Compare
|
@alexlarsson Did you have an opinion on my comment above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already allow normal apps to own MPRIS names but subsandboxes could not.
This allows them with the same dbus restrictions that they must be prefixed by
$app_id.Sandboxed..This will be used by WebKitGTK.