libcurl fixes #5074
Merged
libcurl fixes #5074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. The use of CURLM_OK is a leftover from earlier code that didn't use the easy api. We could fix that, but as you say it doesn't really matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CURLOPT_PROTOCOLS option has been deprecated for CURLOPT_PROTOCOLS_STR in 7.85.0 and using CURLOPT_PROTOCOLS returns an error code.Nvm, I mistook the line numbers, using the deprecated option works fine as of now.A check has also been added to ensure that curl actually supports HTTP2 before trying to use it
Also all the error code checking seems to use CURLM_OK instead of CURLE_OK. Is this intentional? Doesn't matter though since both are defined to 0
The same fixes are required in ostree https://github.com/ostreedev/ostree/blob/main/src/libostree/ostree-fetcher-curl.c#L875-L887