Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export dynamic linker option #5760

Merged
merged 1 commit into from Apr 8, 2024
Merged

Conversation

AngryPenguinPL
Copy link
Contributor

As of LLVM/Clang 18 and LLD18 linker with the -export-dynamic option compilation ends with an error: cc: error: unknown argument: '-export-dynamic'

For GCC and the default compiler this is not a problem. The problem occurs in Clang/LLD 18.

Fix tested on Mandriva via OpenMandrivaAssociation/flatpak@39f1c03

As of LLVM/Clang 18 and LLD18 linker with the -export-dynamic option compilation ends with an error:
cc: error: unknown argument: '-export-dynamic'

For GCC and the default compiler this is not a problem. The problem occurs in Clang/LLD 18.

Fix tested on Mandriva via OpenMandrivaAssociation/flatpak@39f1c03
@smcv
Copy link
Collaborator

smcv commented Apr 8, 2024

I'm not even sure why/whether we need this option (shared libraries export dynamic symbols anyway), but there's certainly no harm in putting it in the format that tells the compiler "pass this opaque option through to the linker".

@smcv smcv merged commit 1f770f3 into flatpak:main Apr 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants