Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake projects that use ECM still default to /lib64 #22

Closed
eszlari opened this issue May 17, 2018 · 3 comments
Closed

cmake projects that use ECM still default to /lib64 #22

eszlari opened this issue May 17, 2018 · 3 comments

Comments

@eszlari
Copy link

eszlari commented May 17, 2018

Installing to /lib64 is supposed to be fixed: 6adb6f4

But cmake based projects that use ECM (extra-cmake-modules) still install in /lib64 when not using -DCMAKE_INSTALL_LIBDIR=lib.
@eszlari
Copy link
Author

eszlari commented May 18, 2018

Maybe @aleixpol @grulja have an idea.

@eszlari
Copy link
Author

eszlari commented May 24, 2018

A similar fix that was applied to GNUInstallDirs (6adb6f4) needs to be applied to KDEInstallDirs:

https://github.com/KDE/extra-cmake-modules/blob/master/kde-modules/KDEInstallDirs.cmake

@alexlarsson @aleixpol @grulja The question is: Should this be fixed upstream or should a patch be added to org.kde.Sdk, like it is the case with GNUInstallDirs?

@eszlari eszlari mentioned this issue May 24, 2018
Merged
@aleixpol
Copy link

https://phabricator.kde.org/D13102

kdesysadmin pushed a commit to KDE/extra-cmake-modules that referenced this issue Jun 5, 2018
@aleixpol
Don't include a 64 when building 64bit architectures on flatpak
5cf0be9 
Summary:
It's not a thing on flatpak and it makes packaging weird.
Should fix flatpak/freedesktop-sdk-base#22

Reviewers: #frameworks, cgiboudeaux

Reviewed By: cgiboudeaux

Subscribers: cgiboudeaux, eszlari, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D13102
@eszlari eszlari closed this as completed Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aleixpol @eszlari