Set a default trust store for GnuTLS #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the changes I am planning in https://bugzilla.gnome.org/show_bug.cgi?id=753260 are going to break glib-networking for Flatpak.
|
I tried building it and the log said: |
|
Perfect, thanks Alex! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the changes I am planning in
https://bugzilla.gnome.org/show_bug.cgi?id=753260 are going to break
glib-networking for Flatpak.
Warning: I failed to successfully compile the freedesktop SDK, so this is untested. I haven't worked with Yocto before and don't know if appending to EXTRA_OECONF in the bbappend file will actually work. But if it's still possible to load HTTPS pages with Epiphany using the updated runtime, then the change at least did not break anything.
It would be desirable to check the build log of GnuTLS and see, at the very bottom of the configure output, if the trust store file was indeed set.
It might be better to try building with
--with-default-trust-store-pkcs11="pkcs11:"instead, which is what Fedora does, but I don't know much about PKCS#11 and wouldn't know how to verify if that's working as expected.