Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong types used in SaveFile() method from FileChooser portal #21

Closed
grulja opened this issue Feb 7, 2020 · 2 comments
Closed

Wrong types used in SaveFile() method from FileChooser portal #21

grulja opened this issue Feb 7, 2020 · 2 comments

Comments

@grulja
Copy link
Contributor

grulja commented Feb 7, 2020 •
edited
Loading

In xdp_portal_save_file() users are expected to pass current_folder and current_file as strings and they seem to be passed to the xdg-desktop-portal that way as well, but the portal expects them as byte array. You can see in documentation [1] that "ay" is expected. This results into failure when doing this call.

[1] - https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.portal.FileChooser.xml#L213
@grulja grulja changed the title Wrong types used in method from FileChooser portal Wrong types used in SaveFile() method from FileChooser portal Feb 7, 2020
@grulja
Copy link
Contributor Author

grulja commented Feb 7, 2020

Looks xdp_portal_save_files() is the same case with current_folder parameter.

@grulja grulja mentioned this issue Feb 11, 2020
Merged
@grulja
Copy link
Contributor Author

grulja commented Feb 12, 2020

Fixed with #23.

@grulja grulja closed this as completed Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grulja