Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatpak-proxy: Tell where "Invalid message header format" comes from #49

Merged
merged 4 commits into from
Aug 7, 2023
Merged

flatpak-proxy: Tell where "Invalid message header format" comes from #49

merged 4 commits into from
Aug 7, 2023

Conversation

hadess
Copy link
Contributor

@hadess hadess commented Jul 19, 2023

Invalid message header format was printed without more details. Printing where the invalid message header came from might help in debugging.

@hadess hadess changed the title flatpak-proxy: Tell where "Invalid message header format" comes from WIP: flatpak-proxy: Tell where "Invalid message header format" comes from Jul 19, 2023
@hadess
Copy link
Contributor Author

hadess commented Jul 19, 2023

I need to add more error reporting to parse_header() it seems.

@hadess hadess force-pushed the wip/hadess/invalid-header-format-debug branch from 052e26a to fadc08f Compare July 20, 2023 08:47
@hadess
Copy link
Contributor Author

hadess commented Jul 20, 2023

Finally something usable :)

** (process:1029439): WARNING **: 10:44:02.354: Invalid message header format from client: Could not parse path in path field

@hadess
Copy link
Contributor Author

hadess commented Jul 20, 2023

Now that's what I call useful debug:

** (process:1032866): WARNING **: 11:02:58.751: Invalid message header format from client: Could not parse path in path field: String is not nul-terminated (/com/intel/dLeynaServer/server/uuid_3ae3dcaa3c_2d5e83_2d39ed_2dcbd5_2dd6e8863f538b/302f312f446973717565206475)

@hadess hadess changed the title WIP: flatpak-proxy: Tell where "Invalid message header format" comes from flatpak-proxy: Tell where "Invalid message header format" comes from Jul 20, 2023
@hadess
flatpak-proxy: Add error reporting to header parsing
c6bf139 
When a header failed to parse, "Invalid message header format" was
printed without more details, making it impossible to debug problems in
the client(s).
@hadess
flatpak-proxy: Add error reporting to string parsing
3e572b4
@hadess hadess force-pushed the wip/hadess/invalid-header-format-debug branch from 7588523 to 26877e6 Compare July 20, 2023 11:21
@hadess
flatpak-proxy: Print parsed header info when parsing fails
c0a1090 
Print the parts of the header that got successfully parsed when parsing
fails.
@hadess hadess force-pushed the wip/hadess/invalid-header-format-debug branch from 26877e6 to c0a1090 Compare July 20, 2023 12:53
@alexlarsson alexlarsson merged commit 8d87ac1 into main Aug 7, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hadess @alexlarsson