Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: Implement the contrast settings #466

Merged
merged 1 commit into from Jan 28, 2024

Conversation

hfiguiere
Copy link
Contributor

See flatpak/xdg-desktop-portal#1175

Note: I still have questions how this work on a non GNOME system.... so it might not be relevant.

Mostly a cut and paste of https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/143

@hfiguiere hfiguiere changed the title settings: Implement the constrast settings settings: Implement the contrast settings Jan 27, 2024
@TingPing
Copy link
Member

Note: I still have questions how this work on a non GNOME system.... so it might not be relevant.

This is the only setting GTK looks at to detect high contrast. Other desktops have to set the GSetting. KDE already sets various GSettings for theme, not sure if they set this one too but that would be changed there.

@dominichayesferen
Copy link

dominichayesferen commented Jan 27, 2024

Note: I still have questions how this work on a non GNOME system.... so it might not be relevant.

This is the only setting GTK looks at to detect high contrast. Other desktops have to set the GSetting. KDE already sets various GSettings for theme, not sure if they set this one too but that would be changed there.

For the record, last I checked they don't... because they don't have High Contrast in that regard yet (until now, the most they have had is an ill-fated Breeze Dark colour scheme edit).

src/settings.c Outdated Show resolved Hide resolved
See flatpak/xdg-desktop-portal#1175

Signed-off-by: Hubert Figuière <hub@figuiere.net>
@TingPing TingPing merged commit dcbc052 into flatpak:main Jan 28, 2024
1 check passed
@hfiguiere hfiguiere deleted the high-contrast branch January 28, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants