Skip to content

Commit

Permalink
Stop linking against libflatpak
Browse files Browse the repository at this point in the history
The configure check for flatpak was a leftover from
when we stopped linking our tests against libflatpak.
We should not bring this back for the main binary.
Instead, ship a standalone copy of FlatpakInstance,
and use that.
  • Loading branch information
Matthias Clasen committed May 15, 2019
1 parent 4f60ff2 commit c80af15
Show file tree
Hide file tree
Showing 5 changed files with 591 additions and 5 deletions.
3 changes: 1 addition & 2 deletions configure.ac
Expand Up @@ -61,7 +61,7 @@ AC_PATH_PROG([BWRAP], [bwrap])
AC_SUBST([GLIB_COMPILE_RESOURCES], [`$PKG_CONFIG --variable glib_compile_resources gio-2.0`])
AC_SUBST([GDBUS_CODEGEN], [`$PKG_CONFIG --variable gdbus_codegen gio-2.0`])

PKG_CHECK_MODULES(BASE, [glib-2.0 gio-2.0 gio-unix-2.0 fontconfig])
PKG_CHECK_MODULES(BASE, [glib-2.0 gio-2.0 gio-unix-2.0 fontconfig json-glib-1.0])
AC_SUBST(BASE_CFLAGS)
AC_SUBST(BASE_LIBS)

Expand Down Expand Up @@ -136,7 +136,6 @@ fi
GLIB_TESTS

PKG_CHECK_MODULES(FUSE, [fuse])
PKG_CHECK_MODULES(FLATPAK, [flatpak])

AC_CONFIG_FILES([
Makefile
Expand Down
4 changes: 2 additions & 2 deletions src/Makefile.am.inc
Expand Up @@ -151,6 +151,8 @@ xdg_desktop_portal_SOURCES = \
src/fc-monitor.h \
src/background.c \
src/background.h \
src/flatpak-instance.c \
src/flatpak-instance.h \
$(NULL)

if HAVE_PIPEWIRE
Expand All @@ -175,7 +177,6 @@ xdg_desktop_portal_LDADD = \
$(BASE_LIBS) \
$(PIPEWIRE_LIBS) \
$(GEOCLUE_LIBS) \
$(FLATPAK_LIBS) \
$(NULL)
xdg_desktop_portal_CFLAGS = \
-DPKGDATADIR=\"$(pkgdatadir)\" \
Expand All @@ -184,7 +185,6 @@ xdg_desktop_portal_CFLAGS = \
$(BASE_CFLAGS) \
$(PIPEWIRE_CFLAGS) \
$(GEOCLUE_CFLAGS) \
$(FLATPAK_CFLAGS) \
-I$(srcdir)/src \
-I$(builddir)/src \
$(NULL)
Expand Down
2 changes: 1 addition & 1 deletion src/background.c
Expand Up @@ -25,13 +25,13 @@
#include <gio/gio.h>
#include <gio/gdesktopappinfo.h>

#include <flatpak.h>
#include "background.h"
#include "request.h"
#include "permissions.h"
#include "xdp-dbus.h"
#include "xdp-impl-dbus.h"
#include "xdp-utils.h"
#include "flatpak-instance.h"

#define PERMISSION_TABLE "background"
#define PERMISSION_ID "background"
Expand Down

0 comments on commit c80af15

Please sign in to comment.