Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tests to set the AppInfo to type HOST with a specific app id #1309

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Allow tests to set the AppInfo to type HOST with a specific app id #1309

merged 5 commits into from
Apr 2, 2024

Commits on Apr 2, 2024

  1. meson.build: xdp-utils is the one using sd-escape.h 

    The only use of the cunescape() functions is in the xdp-utils sources so
let's couple those two together.
    @whot @swick
    whot authored and swick committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    bddf4c5 View commit details
    Browse the repository at this point in the history

  2. xdp-utils: Mark set_appid_from_pid static

    @swick
    swick committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    a3b9ebe View commit details
    Browse the repository at this point in the history

  3. xdp-utils: Introduce an env var to override the AppInfo for tests 

    Tests can run in diverse environments, some of which would get picked up
by our code that tries to find the app id. For tests we need predictable
behavior. Introduce a new environment variable which can be set to an
app id from which a XdpAppInfo of type HOST will be used for all
connections.
    @swick
    swick committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    ae96e17 View commit details
    Browse the repository at this point in the history

  4. tests: Force app id for test-portals and limited-portals 

    Instead of querying x-d-p about the app id, we force the app id that
x-d-p uses for all client connections.
    @swick
    swick committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    5914c84 View commit details
    Browse the repository at this point in the history

  5. tests: Force a default app id for python tests 

    Instead of querying x-d-p about the app id, we force the app id that
x-d-p uses for all client connections.

The `app_id` fixture and PortalMock allow to override this value. The
`app_id` fixture can be used in tests to access the app_id that x-d-p
will see.
    @swick
    swick committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    59cc697 View commit details
    Browse the repository at this point in the history