portal-impl: fix config ordering (supersedes #1240) #1378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to supersede #1240.
Original PR message:
Changes from the original PR include:
none
case sincefind_portal_implementation
returns early if the portal interface prefersnone
.find_portal_implementation
to ensure that the portal implementation selected from the config actually supports the interface.find_default_implementation_iface
to handle the default case, sincefind_portal_implementation
only has access todbus_name
. Thedbus_name
forconfig->default_portal
is always set todefault
, which will never match the name of the interface we are finding the implementation for.find_portal_implementation
.find_all_portal_implementations
as well to ensure consistency.Let me know if any changes are required or if you need to see a diff between the two PRs. I'm
Fixes: #1111