Some cherry-picks from Notifications v2 (!1298) #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a notification may fail, instead of waiting for the timeout we can check the result we get in the callback. Co-authored-by: Georges Basile Stavracas Neto <feaneron@igalia.com>
For debugging it's important that the backend doesn't just crash without telling the reason. It would be even nicer if the test would fail immediately instead of hitting the timeout, but that' currently not possible since the client doesn't know whether the backend failed.
We can reuse most of the test setup for all tests. This will make it easier to test more properties. Co-authored-by: Georges Basile Stavracas Neto <feaneron@igalia.com>
This filters unsupported properties from a notification request without failing it. This allows backwards compatibility after adding new properties. This should had been the case from the beginning so that we don't have to break API when extending the notification interface. See [1]. [1] https://dbus.freedesktop.org/doc/dbus-api-design.html#extensibility Co-authored-by: Georges Basile Stavracas Neto <feaneron@igalia.com>
swick
reviewed
Jun 25, 2024
|
CI also isn't happy |
GeorgesStavracas
force-pushed
the
gbsneto/notifications-v2-cherrypicks-pt1
branch
from
7b4ba49
to
331300c
Compare
Co-authored-by: Georges Basile Stavracas Neto <feaneron@igalia.com>
This allows setting a custom path for the icon validator, especially useful when testing without installing.
The sandbox for the icon-validator needs a privileged container. And it needs librsvg to be able to validate SVGs.
If debug messages are turned on the output of validate-icon isn't a valid key file since it contains log output as well.
GeorgesStavracas
force-pushed
the
gbsneto/notifications-v2-cherrypicks-pt1
branch
from
331300c
to
6bad17d
Compare
GeorgesStavracas
added
tests
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncontroversial commits with mostly testing improvements