Improve installed-tests and run them during Github CI #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works for me on Debian unstable, using: (I know that doesn't run all tests, but in particular it does cover the FUSE document-portal test.) |
|
Fixed in #525 |
|
Fixed in #525 |
smcv
force-pushed
the
installed-tests
branch
4 times, most recently
from
a6569a0
to
e004955
Compare
smcv
changed the title
smcv
force-pushed
the
installed-tests
branch
2 times, most recently
from
d97cf60
to
478bd4e
Compare
|
Rebased on latest #525. |
This is done for two reasons: 1. Logging on stdout can interfere with machine-readable protocols. 2. stdout is normally fully buffered, whereas stderr is normally line-buffered. It's a lot easier to debug the service when messages don't lag behind. Signed-off-by: Simon McVittie <smcv@collabora.com>
These tests produce structured TAP output on stdout, so we cannot run any subprocesses that would produce unstructured stdout. Unfortunately, by default g_debug() writes to stdout, so running with G_MESSAGES_DEBUG to get better logging from the various subprocesses can break the test. Use stderr instead. Signed-off-by: Simon McVittie <smcv@debian.org>
It is not guaranteed that /bin/kill exists and we are already using the bash builtin elsewhere in the script.
Signed-off-by: Simon McVittie <smcv@debian.org>
It has a shebang so no need to pass it to python3 in the tests. It also makes it easier for downstreams to wrap the python file for setting extra environment variables. [smcv: chmod the script +x]
During build-time testing, we need to take special steps to run the just-built version of the portal. However, during "as-installed" testing we want to assert that it was installed correctly, and in particular that D-Bus .service file was installed correctly to make it activatable. Signed-off-by: Simon McVittie <smcv@debian.org>
Signed-off-by: Simon McVittie <smcv@debian.org>
There's no real need to kill it with SIGKILL, and in some configurations there is cleanup that is only performed when allowed to shut down gracefully. Signed-off-by: Simon McVittie <smcv@debian.org>
We want development headers, so libglib2.0-dev rather than libglib2.0-0. Signed-off-by: Simon McVittie <smcv@collabora.com>
Signed-off-by: Simon McVittie <smcv@collabora.com>
smcv
force-pushed
the
installed-tests
branch
from
478bd4e
to
d0b2459
Compare
|
Rebased to reflect #525 having been merged; no practical changes. |
smcv
added a commit
to flatpak/ppa-xdg-desktop-portal
that referenced
this pull request
Sep 10, 2021
This includes upstream 1.7.2-37-g089e72b plus merge request <flatpak/xdg-desktop-portal#521>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #525, #520 and part of #503.
All three commits from Fix openuri test regression (#524) #525, see that PR for details
xdp: Send messages to stderr, not stdout
This is done for two reasons:
Logging on stdout can interfere with machine-readable protocols.
stdout is normally fully buffered, whereas stderr is normally
line-buffered. It's a lot easier to debug the service when messages
don't lag behind.
tests: Divert service stdout to stderr, see PR tests: Divert service stdout to stderr #520 for details
tests: use kill from PATH (from @jtojnar on tests: Try to fix installed tests #503)
It is not guaranteed that /bin/kill exists and we are already using the bash builtin elsewhere in the script.
Install session.conf.in to expected path for installed-tests
tests: call test-document-fuse.py directly (from @jtojnar on tests: Try to fix installed tests #503)
It has a shebang so no need to pass it to python3 in the tests.
It also makes it easier for downstreams to wrap the python file for setting extra environment variables.
[smcv: chmod the script +x]
tests: Only run xdg-document-portal in foreground when uninstalled
During build-time testing, we need to take special steps to run the
just-built version of the portal. However, during "as-installed"
testing we want to assert that it was installed correctly, and in
particular that D-Bus .service file was installed correctly to make it
activatable.
test-document-fuse: Quote more defensively
tests: Send SIGTERM to dbus-daemon
There's no real need to kill it with SIGKILL, and in some configurations
there is cleanup that is only performed when allowed to shut down
gracefully.
CI: Correct the name of the GLib package
We want development headers, so libglib2.0-dev rather than libglib2.0-0.
CI: Run installed-tests
Known omissions:
I'm in the process of getting Pipewire 0.3 into Debian. When that has happened, the run that includes installed-tests could maybe be switched from Ubuntu 18.04 to Debian 11?