remote-desktop: add the ability to communicate via an EIS socket #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2022
whot
force-pushed
the
wip/remote-desktop-eis
branch
from
a6f208b
to
90d13aa
Compare
whot
referenced
this pull request
Nov 28, 2022
When connecting to EIS, this test can never be TRUE, considering that the value is set a few lines below.
whot
force-pushed
the
wip/remote-desktop-eis
branch
from
25fa5ef
to
2622dd4
Compare
|
ftr, we have a working (though not yet complete) use-case in this input-leap PR |
whot
force-pushed
the
wip/remote-desktop-eis
branch
from
2622dd4
to
fe6feaa
Compare
salmanmlk
reviewed
Mar 6, 2023
whot
force-pushed
the
wip/remote-desktop-eis
branch
2 times, most recently
from
b77ebcb
to
16981d3
Compare
whot
force-pushed
the
wip/remote-desktop-eis
branch
3 times, most recently
from
23f46c2
to
a83dc1a
Compare
|
Marking this as ready. There's no immediate libei dependency other than the socket being passed, so even if libei takes another few weeks for the official "it's stable" API this bit is ready. Squashed the commits together, there is no purpose keeping the various bugfixes we had in the git history after the merge. |
whot
force-pushed
the
wip/remote-desktop-eis
branch
from
a83dc1a
to
04f34ee
Compare
|
ftr, libei is now declared stable. Not that it matters for this PR since we don't actually do anything with libei directly. |
whot
force-pushed
the
wip/remote-desktop-eis
branch
2 times, most recently
from
2267eaa
to
eeae17a
Compare
whot
force-pushed
the
wip/remote-desktop-eis
branch
from
eeae17a
to
4627418
Compare
This was referenced Jun 12, 2023
2 tasks
jadahl
reviewed
Jul 6, 2023
whot
force-pushed
the
wip/remote-desktop-eis
branch
from
4627418
to
d0dcf13
Compare
30s is apparently not enough on the runners.
This is intended as replacement for the NotifyFoo methods. libei provides a more flexible and powerful method of sending input events to the compositor. A new method ConnectToEIS requests a file descriptor from the compositor which can then be plugged into libei. Once established, the communication between compositor and application is direct, without the need to go through the portal process(es). To avoid ambiguities between NotifyFoo and input events sent via libei, any application that uses an EIS connection may not use the NotifyFoo methods. Co-authored-by: Olivier Fourdan <ofourdan@redhat.com>
whot
force-pushed
the
wip/remote-desktop-eis
branch
from
d0dcf13
to
37ea85a
Compare
jadahl
approved these changes
Jul 7, 2023
The check_notify() helper returns false for a number of reasons - session in the wrong state, using EIS when a Notify method is called, etc. Adjust the error message a bit to be more generic.
GeorgesStavracas
requested changes
Jul 11, 2023
GeorgesStavracas
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as replacement for the
NotifyFoomethods. libeiprovides a more flexible and powerful method of sending input events to
the compositor.
A new method
ConnectToEISrequests a file descriptor from the compositorwhich can then be plugged into libei.
Once established, the communication between compositor and application
is direct, without the need to go through the portal process(es).
To avoid ambiguities between NotifyFoo and input events sent via libei,
any application that uses an EIS connection cannot use the NotifyFoo
methods.
One notable comment: I decided to pass the EIS connection down through the
impl.portalinstead of pipewire's approach of having the portal connect directly. Unlike the single pipewire daemon, an EIS implementation can be provided by multiple processes, so I figured it's easier to pass this down as close as possible to the entity that knows who the EIS implementationEventually (and once libreis is ready) this will have the hooks to auto-set the app-id on the EIS connection as well though strictly speaking it's not necessary since the app-id is passed down to whoever needs to set up the socket anyway.
Noteworthy: there is no keysym event in libei at this point, so there's no equivalent to NotifyKeyboardKeysym
cc @jadahl