Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aria-labels needed on the time picker inputs #1825

Closed
KLBCWebTeam opened this issue Jun 3, 2019 · 3 comments · Fixed by #1831
Closed

Aria-labels needed on the time picker inputs #1825

KLBCWebTeam opened this issue Jun 3, 2019 · 3 comments · Fixed by #1831

Comments

@KLBCWebTeam
Copy link

KLBCWebTeam commented Jun 3, 2019

Hello,

Could aria-labels be added to the time-picker inputs? See below:

<input class="numInput flatpickr-hour" type="number" tabindex="-1" step="1" min="0" max="23" aria-label="Please select a hour">

<input class="numInput flatpickr-minute" type="number" tabindex="-1" step="5" min="0" max="59" aria-label="Please select a minute">

Kind regards,
KLBC Web Team

P.S. We are pretty happy with the functionality of Flatpickr so I'll take this opportunity to say "great job" :)

  • flatpickr version used: v4.5.7
  • Browser name and version: Chrome - latest
@viorelsfetea
Copy link

@KLBCWebTeam this has been implemented and it will be available in the next version. Please note that you can update the text for each label (hour/minute) by overwriting the locale option when instantiating flatpickr, as follows:

locale: {
      hourAriaLabel: 'Please pick an hour',
      minuteAriaLabel: 'Please pick a minute'
    }

@KLBCWebTeam
Copy link
Author

@viorelsfetea Thank you for making this change. I will look to update our Flatpickr version when it is released. We do our best to keep our site accessible (using SiteImprove to detect any issues) and appreciate the quick turnaround.

@viorelsfetea
Copy link

No worries. I will happily prioritize accessibility updates so, please do report other problems you encounter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants