-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix several rendering issues in IE11 and Edge #1180
Conversation
@@ -4,3 +4,4 @@ index.html | |||
coverage | |||
dist | |||
dist.tar | |||
.DS_Store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This belongs in a global .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really. Sure, it is better to have it in a globsl gitignore file but this is often not the case. The same is with node-debug files, .idea directory and so on.
So far this change wys accepted in any project where I contributed to so it is still legit.
@@ -62,6 +62,7 @@ | |||
animation none | |||
direction ltr | |||
border 0 | |||
display none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No-go. This breaks opening animations for all browsers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which way? I did not see any problem with the default datepicker variant. Using an animation with an early keyframe or an early reset to the needed value in the script to solve this. But so far the high top value and invisible datepicker produces double scrollbars in IE11 and Edge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielRuf noted
@@ -245,6 +246,7 @@ | |||
|
|||
svg | |||
width 14px | |||
height 14px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't noticed any issues with svgs in IE. I'm guessing this fixes a case where they appear huge? How do I reproduce it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theyappear too small in Edge / IE11 as it needs both values as preserveAspect is not used snd the size calculated incorrectly. May be native or in combination with svg4everybody but IE needs both values for right calculations of svg elements.
No description provided.