Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix several rendering issues in IE11 and Edge #1180

Merged
merged 2 commits into from
Feb 3, 2018
Merged

fix several rendering issues in IE11 and Edge #1180

merged 2 commits into from
Feb 3, 2018

Conversation

DanielRuf
Copy link
Contributor

No description provided.

@@ -4,3 +4,4 @@ index.html
coverage
dist
dist.tar
.DS_Store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This belongs in a global .gitignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. Sure, it is better to have it in a globsl gitignore file but this is often not the case. The same is with node-debug files, .idea directory and so on.

So far this change wys accepted in any project where I contributed to so it is still legit.

@@ -62,6 +62,7 @@
animation none
direction ltr
border 0
display none
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No-go. This breaks opening animations for all browsers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which way? I did not see any problem with the default datepicker variant. Using an animation with an early keyframe or an early reset to the needed value in the script to solve this. But so far the high top value and invisible datepicker produces double scrollbars in IE11 and Edge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielRuf noted

@@ -245,6 +246,7 @@

svg
width 14px
height 14px
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't noticed any issues with svgs in IE. I'm guessing this fixes a case where they appear huge? How do I reproduce it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theyappear too small in Edge / IE11 as it needs both values as preserveAspect is not used snd the size calculated incorrectly. May be native or in combination with svg4everybody but IE needs both values for right calculations of svg elements.

@chmln chmln merged commit 684767e into flatpickr:master Feb 3, 2018
@DanielRuf DanielRuf deleted the patch-ie11-edge-rendering branch February 3, 2018 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants