681 show disabled arrows #1264
681 show disabled arrows #1264
Conversation
|
The new functionality is behind a config flag (e.g. |
|
Thanks @imjonrourke for the contribution :) I don't think an option is necessary however. If you wanna show the arrows for whatever reason, you can override this with custom CSS. |
src/index.ts
Outdated
| @@ -872,7 +874,9 @@ function FlatpickrInstance( | |||
| get: () => self.__hideNextMonthArrow, | |||
| set(bool: boolean) { | |||
| if (self.__hideNextMonthArrow !== bool) | |||
| self.nextMonthNav.style.display = bool ? "none" : "block"; | |||
| if (self.config.showDisabledArrows) { | |||
| toggleClass(self.nextMonthNav, "disabled", bool); | |||
There was a problem hiding this comment.
This should be extracted out of the if condition and the else block should be removed.
src/style/flatpickr.styl
Outdated
| @@ -226,6 +226,13 @@ | |||
| transition fill 0.1s | |||
| fill inherit | |||
|
|
|||
| &.disabled | |||
| &, &:hover | |||
There was a problem hiding this comment.
This should go in your application's custom CSS.
The only thing here should be display: none
src/style/flatpickr.styl
Outdated
| @@ -509,8 +516,7 @@ span.flatpickr-weekday | |||
| cursor default | |||
|
|
|||
| &.disabled, &.disabled:hover | |||
| cursor not-allowed | |||
| color alpha($dayForeground, 0.1) | |||
| @extend .flatpickr-prev-month.disabled | |||
There was a problem hiding this comment.
This is not very relevant.
As mentioned, should go in your custom CSS.
Alfredo-Delgado
force-pushed
the
681-show-disabled-arrows
branch
from
4019e36
to
2c611c2
Compare
Alfredo-Delgado
force-pushed
the
681-show-disabled-arrows
branch
from
2c611c2
to
a708388
Compare
|
Updated implementation and tests per code review. |
| @@ -853,17 +853,21 @@ function FlatpickrInstance( | |||
| Object.defineProperty(self, "_hidePrevMonthArrow", { | |||
| get: () => self.__hidePrevMonthArrow, | |||
| set(bool: boolean) { | |||
| if (self.__hidePrevMonthArrow !== bool) | |||
| if (self.__hidePrevMonthArrow !== bool) { | |||
There was a problem hiding this comment.
I'm not sure if you want to keep the if statements, @chmln, so I left them in.
|
Great work, thanks all for contributing 👍 |
|
Thanks for maintaining flatpickr! Do you publish on a schedule? |
|
@Alfredo-Delgado whenever I get free time. the next release is highly anticipated, but with the plethora of recent changes additional testing is necessary to prevent bugs from creeping into users' production. If I gave an ETA it would be within the next 3-5 days |
Resolves #681