fix: do not statically cache today's date #3004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remolueoend
force-pushed
the
master
branch
2 times, most recently
from
4c62b7e
to
f5561e0
Compare
`options.now` is not updated while flatpickr's script files stay in memory. Because `self.now` is initialized with `options.now`, new instances of flatpickr render an outdated date for today if the application itself is not reloaded over multiple days.
|
I just realized that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, first of all thanks for developing and maintaining this library, it proved itself very useful!
I stumbled over the following issue a few days ago: Whenever a user kept my app open over multiple days, flatpickr's value for today is outdated. This affected all flatpickrs instances, even newly created ones.
Turns out that
self.nowof a flatpickr instance is initialized with the value stored inself.options.now. This value is statically initialized and won't be updated as long as the modules stay in memory. I guess that my issue is related to #1633, but redrawing does not help in this case.I am not sure about the reasons behind caching
options.nowand propose to remove it altogether. What do you think?Thanks a lot for looking into my PR,
remolueoend