Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting of saddle connections in byLength() iteration #336

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

saraedum
Copy link
Member

@saraedum saraedum commented Jan 19, 2024

It's curious that this test didn't catch this:

    SECTION("We Find the Same Connections if we Iterate By Length") {
      auto count = 0;
      for (auto connection : square->connections().byLength()) {
        if (connection > Bound(bound, 0))
          break;
        count++;
      }
      REQUIRE(count == expected * 8);
    }

The reason is that we tested with bound in powers of two…

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (edfbc0f) 85.37% compared to head (c8ecade) 85.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #336   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files         107      107           
  Lines        5764     5765    +1     
=======================================
+ Hits         4921     4922    +1     
  Misses        843      843           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saraedum saraedum marked this pull request as ready for review January 19, 2024 23:18
@saraedum saraedum merged commit 17938bc into flatsurf:master Jan 19, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant