fix(hex): fix typing issue for createHexPrototype()

flauwekeul · Apr 22, 2021 · d6e24b4 · d6e24b4
1 parent 39f96c6
commit d6e24b4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/playground/index.ts b/playground/index.ts
@@ -8,8 +8,8 @@ interface CustomHex extends Hex {
 
 const hexPrototype = createHexPrototype<CustomHex>({
   dimensions: 30,
-  orientation: Orientation.POINTY,
-  custom: 'custom', // fixme: adding `orientation: 'flat'` makes this an error, adding `orientation: Orientation.FLAT` doesn't
+  orientation: 'pointy',
+  custom: 'custom',
   origin: 'topLeft',
 })
 // const hex = createHex(hexPrototype, { q: 4, r: 3 })

diff --git a/src/hex/functions/createHexPrototype.ts b/src/hex/functions/createHexPrototype.ts
@@ -18,7 +18,9 @@ export const defaultHexSettings: HexSettings = {
   offset: -1,
 }
 
-export const createHexPrototype = <T extends Hex>(options?: Partial<T | HexPrototypeOptions>): T => {
+export const createHexPrototype = <T extends Hex>(
+  options?: Partial<Omit<T, 'dimensions' | 'orientation' | 'origin' | 'offset'> | HexPrototypeOptions>,
+): T => {
   // pseudo private property
   const s = new WeakMap()