Optimizations #12
Merged
Optimizations #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR addresses issue #1 . |
| /* Exclusive subscanners for strings and escaped hex sequences */ | ||
| %x QUOTMARK_OPEN HEX_OPEN | ||
|
|
||
| /* Extra-JSON rules active iff m_allowSpecialNumbers is true */ |
There was a problem hiding this comment.
|
Thanks for the PR. The code looks really good. Could you please fix the merge conflicts inside of your fork? |
|
Ok, the branch should now apply cleanly to master. I also added the patches you requested in above comments. |
|
Thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are come scanner and parser optimizations, I hope you'll like them :)