This repository has been archived by the owner on Apr 1, 2019. It is now read-only.
Updated chromedriver download methodology. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Utilize S3 bucket XML instead of parsing HTML * Encapsulate download URL logic in GoogleCodeParser * Always re-fetch zip archive, because filenames all look the same * Updated specs.
|
works for me, thanks @mars 👍 |
flavorjones
added a commit
that referenced
this pull request
Aug 26, 2014
Updated chromedriver download methodology.
|
Merged and released in 0.0.6. Thank you, @mars! Apologies to everyone for not seeing and responding to this 10 months ago. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue I reported #7
There is another Pull Request open #8 but that simple patch will always returns chromedriver version 2.4 which will not alway be the newest.