Skip to content
This repository has been archived by the owner on Sep 7, 2021. It is now read-only.

Add new params for UseTLS and Join #4

Closed
wants to merge 1 commit into from

Conversation

ercollin
Copy link

Added 2 new params:

  1. UseTLS so this can be disabled when connecting to an internal IRC server not using TLS
  2. Join which will first Join the channel before posting the message, then leave it. Seems to be required on ngircd.

@flavorjones
Copy link
Owner

@ercollin Thank you for submitting this!

Sorry for my slow reply -- I didn't have notifications turned on so I just saw this now.

Give me a day or two to take a look at these changes and get CI set up. Thank you!

This was referenced Dec 10, 2018
@flavorjones
Copy link
Owner

flavorjones commented Dec 11, 2018

@ercollin I've rebased this commit against master on another branch, so don't worry about doing that. Should be able to merge this and cut a release in the next day or so.

@flavorjones
Copy link
Owner

Merged manually! Thank you for this contribution. I'll update the README and acknowledge you in the CHANGELOG (which I need to create!).

@flavorjones
Copy link
Owner

One quick note: I did make a subsequent commit to ensure that UseTLS continued to default to true. I would have considered that to be a breaking change.

Thanks again!

@flavorjones
Copy link
Owner

v1.1.0 has been shipped and is up on DockerHub. Let me know how it goes!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants