Fix CHANGELOG url in gemspec #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @HusseinMorsy - I'm sorry, I didn't see this PR before you closed it. Please note that the |
|
@flavorjones no problem. thanks for your feedback. |
flavorjones
added a commit
that referenced
this pull request
Jun 7, 2020
this mistake was originally pointed out by @HusseinMorsy in #185 and @rafbm in #186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently added changelog url in gemspec does not work:
https://github.com/flavorjones/loofah/master/CHANGELOG.md
See also on RubyGems.
The correct url is https://github.com/flavorjones/loofah/blob/master/CHANGELOG.md
It is also recommended to use the version number in the url: https://github.com/flavorjones/loofah/blob/v2.5.0/CHANGELOG.md
I have not only corrected the URL, but also added a a version specific url to the changelog and to the rubydocs.