feat: adds :targetblank scrubber
#275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`:targetblank` adds a `target="_blank"` attribute to all links. If there is a target already set, replaces it with `target="_blank"`. ``` link_farmers_markup = "ohai! <a href='http://www.myswarmysite.com/'>I like your blog post</a>" Loofah.html5_fragment(link_farmers_markup).scrub!(:targetblank) => "ohai! <a href='http://www.myswarmysite.com/' target="_blank">I like your blog post</a>" ``` Co-authored-by: Thiago Araujo <thd.araujo@gmail.com>
|
CI errors seem to be related to rubygems/rubygems#7064 |
|
seems related to jruby/jruby#7962 |
|
@flavorjones this one is passing now :) |
|
Looks great! Thank you so much. Merging. |
|
Just released https://github.com/flavorjones/loofah/releases/tag/v2.22.0 with this in it! Thank you again! |
|
Does this introduce a security issue without the |
|
@n00dle Thanks for asking this question. The assumption is that people who are using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fixes #272]
New scrubber
:targetblank- adds atarget="_blank"attribute to all links. If there is a target already set, replaces it withtarget="_blank".(co-authored by @thdaraujo)