cmake: Support cmake command replacement on #initialize #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
force-pushed
the
support-replace-cmake-command-via-initialize
branch
from
701809c
to
1f09016
Compare
flavorjones
force-pushed
the
support-replace-cmake-command-via-initialize
branch
from
1f09016
to
e239867
Compare
|
@cosmo0920 Thank you for this contribution! I've added some commits to this PR to make the If this goes green in CI then I'll merge and cut a release. |
flavorjones
force-pushed
the
support-replace-cmake-command-via-initialize
branch
3 times, most recently
from
baadd84
to
fa0c687
Compare
- MiniPortile initializer takes optional keyword arguments - the methods gcc_cmd and make_cmd are now public - allow configuration of gcc and make commands - new public method cmake_cmd, and configurable cmake command - update README with configuration instructions Signed-off-by: Hiroshi Hatake <hatake@calyptia.com> Co-authored-by: Hiroshi Hatake <hatake@calyptia.com>
flavorjones
force-pushed
the
support-replace-cmake-command-via-initialize
branch
from
fa0c687
to
8d9401e
Compare
|
Released in v2.7.0 |
|
Wow, thanks for the quick releasing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For CentOS, RHEL, and Amazon Linux 2 use case, we sometimes need to use
cmake3command instead ofcmakecommand.Could you provide how to specify arbitrary cmake command at
#initializeonMiniPortileCMakeclass?Signed-off-by: Hiroshi Hatake hatake@calyptia.com