Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations not up 2 date #70

Closed
ghost opened this issue Jan 23, 2019 · 3 comments · Fixed by #71
Closed

Migrations not up 2 date #70

ghost opened this issue Jan 23, 2019 · 3 comments · Fixed by #71
Labels

Comments

@ghost
Copy link

ghost commented Jan 23, 2019

when we run makemigrations a new migration in /graphql_jwt/refresh_token/migrations/0002_auto_20190123_1648.py gets created with the following content:

from django.db import migrations


class Migration(migrations.Migration):

    dependencies = [
        ('refresh_token', '0001_initial'),
    ]

    operations = [
        migrations.AlterModelOptions(
            name='refreshtoken',
            options={'verbose_name': 'refresh token', 'verbose_name_plural': 'refresh tokens'},
        ),
    ]

in ci we check if any uncreated migrations exist. if yes it stops the deployment. This happens because.

in https://github.com/flavors/django-graphql-jwt/blob/v0.2.0/graphql_jwt/refresh_token/migrations/0001_initial.py

'verbose_name': 'Refresh token', # uppercase, line 27
'verbose_name_plural': 'Refresh tokens', # uppercase, line 28

but in https://github.com/flavors/django-graphql-jwt/blob/v0.2.0/graphql_jwt/refresh_token/models.py

verbose_name = _('refresh token')  # lowercase, line 35
verbose_name_plural = _('refresh tokens') # lowercase, line 36
@ghost ghost mentioned this issue Jan 23, 2019
@mongkok mongkok added the bug label Jan 29, 2019
@mongkok
Copy link
Member

mongkok commented Jan 30, 2019

Hi @onceatime !,
I prefer to use lowercase,
could you update the migration to lowercase instead of the model class?

Thanks.

@ghost
Copy link
Author

ghost commented Jan 30, 2019

@mongkok done, but as mentioned flake8 has a lot of errors in travis check. Try to fix them for future but currently i don't have time... it looks better in two weeks.

#71

@mongkok
Copy link
Member

mongkok commented Jan 30, 2019

@onceatime thanks!

tim-schilling pushed a commit to tim-schilling/django-graphql-jwt that referenced this issue Jan 10, 2022
Bumps [django](https://github.com/django/django) from 3.2.6 to 3.2.7.
- [Release notes](https://github.com/django/django/releases)
- [Commits](django/django@3.2.6...3.2.7)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant