[v2.2.0] Stricten Lints & Fix Tests Exceptions #1319

lsaudon · 2022-07-25T18:37:10Z

strong-mode is deprecated. It should be replaced by language. Enabling stricter type checks

The exception type 'Null' is not a subtype of type 'HttpHeaders' does not appear in tests anymore.

Add sames rules for example

Replace dynamic by the right type when possible.

JaffaKetchup

Hi there, and thanks for your contribution. However, there's a few things that need to be changed.

lib/src/layer/tile_layer/tile_provider/network_no_retry_image_provider.dart

example/lib/pages/overlay_image.dart

pablojimpas · 2022-07-29T19:16:37Z

The strict-casts mode was introduced in Dart 2.16, right now we support all the way back to 2.12.0

flutter_map/pubspec.yaml

Line 8 in 2d2a956

sdk: ">=2.12.0 <3.0.0"

I'm okay with applying the code changes to satisfy new linter rules, but we should either drop support for earlier versions of Dart (which I think it's not worth it) or left the pubspec.yaml untouched.

lib/src/geo/crs/crs.dart

Co-authored-by: Polo <gitpjp@pm.me>

JaffaKetchup

I agree with @pablojimpas, I think backwards-compatibility is important, and we need to support Dart 2.12 for now at least.

Also, please stop ignoring close_sinks for the whole library, and just ignore it where I previously asked. It's a useful lint to have, and in this case, it's a false positive.

lsaudon · 2022-07-30T20:13:29Z

I agree with @pablojimpas, I think backwards-compatibility is important, and we need to support Dart 2.12 for now at least.

Also, please stop ignoring close_sinks for the whole library, and just ignore it where I previously asked. It's a useful lint to have, and in this case, it's a false positive.

I did not add ignoring close_sinks for the lib. The rule was already there.
I just put the same rules in the example.

Edit:
I don't really understand because according to the history of the analysis_options.yaml file, the rule was never present.

analysis_options.yaml

JaffaKetchup

As above.

JaffaKetchup

Yeah the checks are still failing, so the 'ignore' line in the tile provider needs to be added back. Let's keep the analysis_options.yaml without the ignore statement though.

lsaudon · 2022-07-30T20:33:22Z

Yeah the checks are still failing, so the 'ignore' line in the tile provider needs to be added back. Let's keep the analysis_options.yaml without the ignore statement though.

It's weird because I ran the same commands as in the CLI and this error doesn't appear.

JaffaKetchup · 2022-07-30T20:37:47Z

Yeah - I had this same situation as well. It's because the new package score analyser workflow I added uses a different lint set, so only that one fails: https://github.com/axel-op/dart-package-analyzer. Theoretically, this means that the pub.dev score for this package, should this have been pushed without this change, would have only been 120/130.

JaffaKetchup · 2022-07-30T20:41:09Z

@pablojimpas Thanks for the heads-up, but I'm a bit confused. How should we support Dart 2.12? When you said 'leave the pubspec untouched', this PR hasn't changed it. Please can you clarify?

Once Dart 2.12 is supported, this should be good to go.

lsaudon · 2022-07-30T20:59:59Z

Yeah - I had this same situation as well. It's because the new package score analyser workflow I added uses a different lint set, so only that one fails: https://github.com/axel-op/dart-package-analyzer. Theoretically, this means that the pub.dev score for this package, should this have been pushed without this change, would have only been 120/130.

The package "dart-package-analyzer" does not use the same rules as the package "Pana" that gives the score pub.dev.

I think we should at least have the same rules as the package "dart-package-analyzer".

JaffaKetchup · 2022-07-30T21:08:35Z

You might be right, in which case, we should probably just disable this check I added, because I'm not sure you can change the lint rules it uses.
I'll revert my PR or open a new one tomorrow.

lsaudon · 2022-07-30T21:48:05Z

You might be right, in which case, we should probably just disable this check I added, because I'm not sure you can change the lint rules it uses.
I'll revert my PR or open a new one tomorrow.

No, don't revert your PR, we can just add the rules and regulations if we have to.

JaffaKetchup · 2022-07-30T21:49:54Z

I'm not sure how to do that, so feel free to do so here :)

lsaudon · 2022-07-31T06:41:48Z

Ok, I found the rules that pana uses, I added the one that was not in flutter_lints.
I removed the rules that were already defined by flutter_lints.
I sorted the rules.

The rules use by pana analysis_options.dart

JaffaKetchup · 2022-08-01T19:43:18Z

OK, that seems good to me I think. @ibrierley Any opinions?

ibrierley · 2022-08-01T20:01:37Z

No opinions from me!

JaffaKetchup

LGTM. Quite a large changeset, but I think it's all good. Many thanks for your contributions!

lsaudon added 3 commits July 25, 2022 22:16

chore: strong-mode is deprecated

10245f6

fix: Exception on flutter_map_test

719d5f6

chore: Example has the same rules as the package

6edd024

lsaudon changed the title ~~linter & fix: strong-mode is obsolete and exception on flutter_map_test~~ chore, fix and refacto: strong-mode is depreacted, exception on flutter_map_test, sames rules for example, replace dynamic Jul 25, 2022

refacto: replace dynamic by the right type

5517d7e

JaffaKetchup requested review from ibrierley and JaffaKetchup July 26, 2022 20:44

JaffaKetchup changed the title ~~chore, fix and refacto: strong-mode is depreacted, exception on flutter_map_test, sames rules for example, replace dynamic~~ Fix Test Bugs & Tighten Lints Jul 26, 2022

JaffaKetchup changed the title ~~Fix Test Bugs & Tighten Lints~~ Stricten Lints & Fix Tests Exceptions Jul 26, 2022

JaffaKetchup changed the title ~~Stricten Lints & Fix Tests Exceptions~~ [v2.2.0] Stricten Lints & Fix Tests Exceptions Jul 26, 2022

Merge branch 'master' into master

a6fb00f

JaffaKetchup requested changes Jul 29, 2022

View reviewed changes

lib/src/layer/tile_layer/tile_provider/network_no_retry_image_provider.dart Outdated Show resolved Hide resolved

example/lib/pages/overlay_image.dart Outdated Show resolved Hide resolved

JaffaKetchup mentioned this pull request Jul 29, 2022

Prepared For v2.2.0 Release #1324

Merged

Change OverlayImage to BaseOverlayImage

860d5d2

lsaudon requested a review from JaffaKetchup July 29, 2022 16:07

pablojimpas suggested changes Jul 29, 2022

View reviewed changes

lib/src/geo/crs/crs.dart Outdated Show resolved Hide resolved

lib/src/geo/crs/crs.dart Outdated Show resolved Hide resolved

fix: compareTo is useless now

dd45448

Co-authored-by: Polo <gitpjp@pm.me>

JaffaKetchup requested changes Jul 30, 2022

View reviewed changes

JaffaKetchup self-requested a review July 30, 2022 20:17

JaffaKetchup reviewed Jul 30, 2022

View reviewed changes

analysis_options.yaml Outdated Show resolved Hide resolved

Update analysis_options.yaml

97f8d76

JaffaKetchup approved these changes Jul 30, 2022

View reviewed changes

JaffaKetchup self-requested a review July 30, 2022 20:26

JaffaKetchup requested changes Jul 30, 2022

View reviewed changes

Readded ignore close_sinks

95fe69e

JaffaKetchup self-requested a review July 30, 2022 20:38

Add same rules of pana

bf93ac1

JaffaKetchup approved these changes Aug 2, 2022

View reviewed changes

JaffaKetchup merged commit 30ca5de into fleaflet:master Aug 2, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v2.2.0] Stricten Lints & Fix Tests Exceptions #1319

[v2.2.0] Stricten Lints & Fix Tests Exceptions #1319

lsaudon commented Jul 25, 2022 •

edited

JaffaKetchup left a comment

pablojimpas commented Jul 29, 2022

JaffaKetchup left a comment

lsaudon commented Jul 30, 2022 •

edited

JaffaKetchup left a comment

JaffaKetchup left a comment •

edited

lsaudon commented Jul 30, 2022

JaffaKetchup commented Jul 30, 2022 •

edited

JaffaKetchup commented Jul 30, 2022

lsaudon commented Jul 30, 2022

JaffaKetchup commented Jul 30, 2022

lsaudon commented Jul 30, 2022 •

edited

JaffaKetchup commented Jul 30, 2022

lsaudon commented Jul 31, 2022 •

edited

JaffaKetchup commented Aug 1, 2022

ibrierley commented Aug 1, 2022

JaffaKetchup left a comment

[v2.2.0] Stricten Lints & Fix Tests Exceptions #1319

[v2.2.0] Stricten Lints & Fix Tests Exceptions #1319

Conversation

lsaudon commented Jul 25, 2022 • edited

JaffaKetchup left a comment

Choose a reason for hiding this comment

pablojimpas commented Jul 29, 2022

JaffaKetchup left a comment

Choose a reason for hiding this comment

lsaudon commented Jul 30, 2022 • edited

JaffaKetchup left a comment

Choose a reason for hiding this comment

JaffaKetchup left a comment • edited

Choose a reason for hiding this comment

lsaudon commented Jul 30, 2022

JaffaKetchup commented Jul 30, 2022 • edited

JaffaKetchup commented Jul 30, 2022

lsaudon commented Jul 30, 2022

JaffaKetchup commented Jul 30, 2022

lsaudon commented Jul 30, 2022 • edited

JaffaKetchup commented Jul 30, 2022

lsaudon commented Jul 31, 2022 • edited

JaffaKetchup commented Aug 1, 2022

ibrierley commented Aug 1, 2022

JaffaKetchup left a comment

Choose a reason for hiding this comment

lsaudon commented Jul 25, 2022 •

edited

lsaudon commented Jul 30, 2022 •

edited

JaffaKetchup left a comment •

edited

JaffaKetchup commented Jul 30, 2022 •

edited

lsaudon commented Jul 30, 2022 •

edited

lsaudon commented Jul 31, 2022 •

edited