Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jitter of polygon/polyline after reverting from 2-step positioning #1514

Merged
merged 1 commit into from May 12, 2023

Conversation

ignatz
Copy link
Contributor

@ignatz ignatz commented May 11, 2023

Previously, the canvas was positioned in two steps using a Positioned widget, which was removed due to its own precision issues. Now the canvas needs to be redrawn whenever the viewport changes, not just rotations and zooming but also panning.

…irect positioning.

Previously, the canvas was positioned in two steps using a Positioned widget, which was removed due to its own precision issues. Now the canvas needs to be redrawn whenver the viewport changes, not just rotations and zooming but also panning.
@JaffaKetchup
Copy link
Member

Hey @ignatz.
Please also note #1513: we think the batching changes may have caused some issues when rendering polylines with borders - not sure how we didn't catch this before!
Fixes for the broken status checks (support for Flutter 3.10) available in #1512.

@ignatz
Copy link
Contributor Author

ignatz commented May 11, 2023

Hey @ignatz. Please also note #1513: we think the batching changes may have caused some issues when rendering polylines with borders - not sure how we didn't catch this before!

Why the "saveLayers" issue wasn't caught is probably easy to answer: there are no tests, no examples, and the docstring seems to discourage its use.

As to this fix, this is unrelated.

Fixes for the broken status checks (support for Flutter 3.10) available in #1512.

Unrelated to this fix but FYI, I was able to convert my App to Flutter 3.10 w/o many issues. I guess that's due to the use of my own custom tile provider 🤷

@JaffaKetchup
Copy link
Member

JaffaKetchup commented May 11, 2023

Unrelated to this fix but FYI, I was able to convert my App to Flutter 3.10 w/o many issues. I guess that's due to the use of my own custom tile provider 🤷

Yeah, everything is working, but the checks aren't - there have been some deprecations and stuff.

@JaffaKetchup
Copy link
Member

(Please pull from master. Only Flutter 3.10 is now supported.)

@JaffaKetchup JaffaKetchup self-requested a review May 12, 2023 09:00
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks :)

@JaffaKetchup JaffaKetchup merged commit 0d522d2 into fleaflet:master May 12, 2023
5 of 6 checks passed
@ignatz ignatz deleted the fix_poly branch May 12, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants