Fix polygon draw batching #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectly setting the border color. I also feel that the code re-organization really helped the separation of concerns and made it much clearer what each part is doing. Specifically: * Fill and border are clearly separated. * The loop is only responsible for batching paths. The Paint is now handled once during drawing.
JaffaKetchup
requested review from
ibrierley,
mootw,
TesteurManiak and
JaffaKetchup
…lygons have opposing normals. This is a feature of canvas for cutting holes. This feature might actually be handing for simplifying our hole cutting code, however in this case we don't want it. This is leaky, since this only applies when polygons would be batched, i.e. they have identical properties, they're overlapping, and their points have opposing normals.
ignatz
force-pushed
the
fix_polygon_draw_batching
branch
from
9841e3b
to
56fd434
Compare
JaffaKetchup
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a pre-existing condition and is independent from the cleanup. The cleanup is more a result of my debugging. The commits could be split.