Increase scope of polygon draw batching for polygons with labels. #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…els to allow reusing the same polygons while toggling the labels, e.g. depending on zoom level. Also a bunch of small optimizations to minimize canvas operations (save/restore) and reduce strain on garbage collection (fewer ephemeral allocations)
…ls only if the label would actually be drawn, as determined by the layouting algorithm.
|
I was just thinking that if this contains all of the other, and this one includes better optimizations, why not prefer this one instead? Have I missed something? |
No, missing nothing :). This is a clear superset. Visually both changes are noops (minus the "padding"). |
JaffaKetchup
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change contains all previous micro-optimizations plus a larger optimization extending the scope and applicability of polygon draw batching.
Previously, we'd eagerly flush a batch whenever we'd encounter a polygon with a label. However, depending on the rendered polygon and label size, it would never be drawn. In this case we don't have to and should flush.
From a composition and visual point of view, this change is a noop.