Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add doubleTapDragZoom and scrollWheelZoom to InteractiveFlag.all #1726

Merged
merged 3 commits into from Nov 12, 2023

Conversation

amal-stack
Copy link
Contributor

Fixes #1725.

@JaffaKetchup
Copy link
Member

Thanks for writing this @amal-stack!
We're just having some internal conversation about what's next exactly, and how this relates with #1724. Hopefully we'll get around to merging this, or resolving the issue another way, soon.

@JaffaKetchup JaffaKetchup changed the title Add doubleTapDragZoom and scrollWheelZoom to InteractiveFlag.all fix: add doubleTapDragZoom and scrollWheelZoom to InteractiveFlag.all Nov 10, 2023
@JaffaKetchup JaffaKetchup self-requested a review November 12, 2023 14:28
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this! Note that #1730 is required to make this fix work properly.

@JaffaKetchup JaffaKetchup merged commit 1bee1be into fleaflet:master Nov 12, 2023
6 checks passed
josxha pushed a commit to josxha/flutter_map that referenced this pull request Nov 28, 2023
…g.all` (fleaflet#1726)

Co-authored-by: JaffaKetchup <github@jaffaketchup.dev>
josxha pushed a commit that referenced this pull request Nov 28, 2023
…g.all` (#1726)

Co-authored-by: JaffaKetchup <github@jaffaketchup.dev>
josxha pushed a commit that referenced this pull request Nov 28, 2023
…g.all` (#1726)

Co-authored-by: JaffaKetchup <github@jaffaketchup.dev>
@josxha josxha added this to the v6.1 milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] InteractiveFlags.all does not include doubleTapDragZoom and scrollWheelZoom
3 participants