Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: close issues with no user response #1804

Merged
merged 12 commits into from
Feb 6, 2024

Conversation

josxha
Copy link
Contributor

@josxha josxha commented Jan 21, 2024

  • This pull request marks issues with the waiting for user response label automatically stale after 3 weeks. This is a reminder for the user to answer a question or provide requested information.
  • After another week with no activity / user response, the issue gets closed automatically.
  • If the user responds within the week the waiting for user response and stale label gets automatically removed.

diagram (1)

@josxha josxha added the S: core Scoped to the core flutter_map functionality label Jan 21, 2024
@JaffaKetchup JaffaKetchup removed the S: core Scoped to the core flutter_map functionality label Jan 21, 2024
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mixed feelings about this. We previously had this stale bot (admittedly without the tag exception rules), but it was a bit of a pain. Even if 50% of bug reports without enough information are invalid, that still leaves 50% that would be better investigated. Leaving them open allows other people to find issues and add their own info.
Would like some input from the others (@ibrierley, @TesteurManiak, @mootw).

@josxha
Copy link
Contributor Author

josxha commented Jan 21, 2024

(There is currently one problem with this PR: The waiting for user response will not get removed if the issue is not stale.)


We previously had this stale bot (admittedly without the tag exception rules), but it was a bit of a pain.

I'm aware that this was used in the past. While it was configured to close all issues in the past, this pr gives automation for the waiting for user response label. It will only handle those and ignore all other issues.

Having some kind of automation around waiting for user response is required to ensure the label gets removed when it recieves an update. For my understanding waiting for user response is a useful label if an issue can't be reproduced or requires the answer to an question to be able to get solved.

#1760 is a good example what happens if we don't have this automation.

Even if 50% of bug reports without enough information are invalid, that still leaves 50% that would be better investigated.

It wouldn't make sense for us to tag those other 50% of valid bug reports with waiting for user response, therefore I can't see your argument here.

Leaving them open allows other people to find issues and add their own info.

It is still possible for other people to adopt such issues. As soon as an update gets posted the waiting for user response would get removed.

@josxha josxha marked this pull request as draft January 21, 2024 14:45
@JaffaKetchup

This comment was marked as outdated.

@josxha

This comment was marked as outdated.

@josxha josxha marked this pull request as ready for review February 6, 2024 15:09
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor changes to wording, let me know what you think of them.

.github/workflows/daily.yml Outdated Show resolved Hide resolved
.github/workflows/daily.yml Outdated Show resolved Hide resolved
josxha and others added 3 commits February 6, 2024 16:15
Co-authored-by: Luka S <github@jaffaketchup.dev>
* Update issue-comment.yml

* Update issue-comment.yml
Co-authored-by: Luka S <github@jaffaketchup.dev>
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks :)

@josxha
Copy link
Contributor Author

josxha commented Feb 6, 2024

I tested the workflows on my fork, hope I fixed every bug.
Merging it.

@josxha josxha merged commit 04cf4e9 into fleaflet:master Feb 6, 2024
6 checks passed
@josxha josxha deleted the close-issues-with-no-user-response branch February 6, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants