Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 100% documented public members #1838

Merged
merged 5 commits into from
Feb 26, 2024
Merged

feat: 100% documented public members #1838

merged 5 commits into from
Feb 26, 2024

Conversation

josxha
Copy link
Contributor

@josxha josxha commented Feb 22, 2024

  • Adds doc strings to all missing public members
  • With this pr public_member_api_docs will get active. This enforces future PRs to keep the 100% documentation score of public members. Private members won't be affected.

@josxha josxha self-assigned this Feb 22, 2024
@josxha josxha added this to the v7.0 milestone Feb 22, 2024
JaffaKetchup
JaffaKetchup requested changes Feb 23, 2024
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just a few things to think about...

lib/src/gestures/interactive_flag.dart Outdated Show resolved Hide resolved
lib/src/layer/attribution_layer/rich/source.dart Outdated Show resolved Hide resolved
lib/src/layer/polygon_layer/polygon.dart Outdated Show resolved Hide resolved
lib/src/layer/tile_layer/tile_coordinates.dart Show resolved Hide resolved
lib/src/layer/tile_layer/tile_image_view.dart Outdated Show resolved Hide resolved
JaffaKetchup
JaffaKetchup approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@JaffaKetchup JaffaKetchup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Huge thanks, a lot of work here.

@josxha josxha merged commit e0300c0 into fleaflet:master Feb 26, 2024
7 checks passed
@josxha josxha deleted the add-doc-strings branch February 26, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaffaKetchup JaffaKetchup JaffaKetchup approved these changes

Assignees

@josxha josxha

Labels
None yet
Projects
Development
Archived in project
Milestone
v7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josxha @JaffaKetchup