feat: optimization of "solid" polygon/polyline display

[monsieurtanuki]

What

Optimized the algorithm for "solid" polygon/polyline display.
The trick is to use addPolygon instead of numerous moveTo/lineTo. It looked like removing redundant moveTos was quite effective, too.

Following are some perf tests. We're getting closer to the old solid algorithm (that we had to dismiss because of bugs in 25+ zooms).

x	old solid algo	new solid algo	current PR
Raster (ms)	206.2	578.9	208.6
UI (ms)	42.1	53.2	49.6

Impacted files

• polygon_layer/painter.dart: minor refactoring
• polyline_layer/painter.dart: minor refactoring
• pixel_hiker.dart: optimized the "solid pixel hiker" relying on addPolygon instead of numerous moveTo/lineTo

Screenshots

[JaffaKetchup]

Hey @monsieurtanuki,

Thanks for continuing to work on this! I've been testing this PR and have noticed that there's an issue on the master branch and on this PR, that could be related. Not sure whether it's worth fixing in a different PR, or this PR, but needs to be fixed for sure.

It looks like the culling algortihm no longer accounts for the radius of the line, so it's possible to see the radius of the curve at the edges of the viewport.

[monsieurtanuki]

Hi @JaffaKetchup!

Probably not related to culling, but to drawing segments clipped to screen rectangle instead of a continuous polygon.
Could be fixed by pretending that the screen is slightly bigger: an extra half radius on each side of the clipping screen rectangle.

[monsieurtanuki]

Hi @JaffaKetchup!
I've just fixed the issue, that was more obvious for solid lines but impacted dashed and dotted lines too.
As expected, the idea was just to take into account the stroke width when we clip segments into the screen.
Instead of clipping into
[0, 0, canvas.width, canvas.height]
we have to clip into
[-strokeWidth/2, -strokeWidth/2, canvas.width+strokeWidth/2, canvas.height/strokeWidth/2].
Et voilà!

x	before	after
polyline
polygon

[JaffaKetchup]

I'll try to review this tomorrow :)

[JaffaKetchup]

LGTM I think! Thanks once again :)