Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(example): added WASM support to example #1885

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JaffaKetchup
Copy link
Member

@JaffaKetchup JaffaKetchup commented May 16, 2024

Supersedes #1867 by @josxha.

  • Reset web index.html config file to initial state in Flutter 3.22
  • Also adds required headers to Firebase config (hopefully)

Would like to add an indicator using dart-lang/sdk/issues/55694 when it becomes available, to confirm usage of WASM.

@josxha
Copy link
Contributor

josxha commented May 16, 2024

Also adds required headers to Firebase config (hopefully)

It's possible to deploy branches temporarily on firebase hosting, see https://github.com/FirebaseExtended/action-hosting-deploy?tab=readme-ov-file#channelid-string.
Maybe a good way to test those changes or even to setup a permanent hosted version running on wasm?

@JaffaKetchup
Copy link
Member Author

It's possible to deploy branches temporarily on firebase hosting, see FirebaseExtended/action-hosting-deploy#channelid-string.

Yep, I've looked into this extensively before. However, I disabled it, as most of our PRs come from forks, and for security reasons, GitHub Actions and Firebase won't do this from a fork PR. I can try deploying a preview version manually perhaps?

@JaffaKetchup
Copy link
Member Author

https://fleaflet-firebase--preview-wasm-bfczu5tt.web.app/

Can confirm it doesn't work, but only because the CTP uses Dio which doesn't support Dio yet. Not sure why I couldn't reproduce this locally, but I guess we'll have to hold off for now.

@JaffaKetchup JaffaKetchup marked this pull request as draft May 16, 2024 19:53
@josxha
Copy link
Contributor

josxha commented May 16, 2024

Open pull request here:


While I tested my branch I had the problem that the polygon stresstest page gets stuck and doesn't seem to unfreezed after i zoomed in. Does this happen here too?

@JaffaKetchup
Copy link
Member Author

Waiting for:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants