Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overlapping Polygon cutting & color/translucency mixing #1901

Merged
merged 3 commits into from
Jun 8, 2024

Conversation

JaffaKetchup
Copy link
Member

Fixes #1898.

Note that these new measures to ensure correct functionality could negatively impact performance. This is properly documented.

Fixed issue where `Polygon`s with translucent colors wouldn't have their colors mixed correctly on painting
Added example of these two issues to Polygon example
Improved documentation (to include performance considerations of these points)
@JaffaKetchup JaffaKetchup requested review from mootw and josxha June 1, 2024 12:08
@JaffaKetchup JaffaKetchup changed the title fix: fixed overlapping Polygon cutting & Polygon translucency treatment fix: fixed overlapping Polygon cutting & translucency mixing Jun 1, 2024
JaffaKetchup

This comment was marked as resolved.

@JaffaKetchup JaffaKetchup changed the title fix: fixed overlapping Polygon cutting & translucency mixing fix: overlapping Polygon cutting & color/translucency mixing Jun 1, 2024
lib/src/layer/polygon_layer/painter.dart Outdated Show resolved Hide resolved
@josxha
Copy link
Contributor

josxha commented Jun 7, 2024

I did some quick testing and all works like excepted. Good job!

@JaffaKetchup JaffaKetchup merged commit 0167891 into master Jun 8, 2024
8 checks passed
@JaffaKetchup JaffaKetchup deleted the fix-1898 branch June 8, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Overlapping Polygons with same colors cause cutting
2 participants